Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with Python <3.10 #2

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Improve compatibility with Python <3.10 #2

merged 1 commit into from
Jul 28, 2022

Conversation

mxsasha
Copy link
Contributor

@mxsasha mxsasha commented Jul 28, 2022

Haven't run full compatibility tests, but this was a definite 3.10 only syntax, and 3.8/3.9 are still used wide enough that it's worth such a small change.

Haven't run full compatibility tests, but this was a definite 3.10 only syntax, and 3.8/3.9 are still used wide enough that it's worth such a small change.
Copy link
Contributor

@fangpenlin fangpenlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the contribution 👍

@fangpenlin fangpenlin merged commit db5f292 into LaunchPlatform:master Jul 28, 2022
@fangpenlin
Copy link
Contributor

Just realized that my poetry file still using 3.9 as the minimal python version, I will change that as well.

python = "^3.9"

@mxsasha
Copy link
Contributor Author

mxsasha commented Feb 23, 2023

Just realized that my poetry file still using 3.9 as the minimal python version, I will change that as well.

@fangpenlin Thanks for fixing this! I see it was released on github but does not seem to have made it to PyPI? That's still on 0.1.3 as latest.

@fangpenlin
Copy link
Contributor

@mxsasha thanks for the heads up. yeah, turned out last time I forgot to bump the version number in poetry file and CI job for pushing the package to pypi as old release already exists. I've fixed that issue and published a new release 0.1.6, and it's available on PyPi now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants