Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various soundbank fixes #264

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Various soundbank fixes #264

merged 9 commits into from
Sep 19, 2024

Conversation

Jbleezy
Copy link
Contributor

@Jbleezy Jbleezy commented Sep 16, 2024

Closes #138 if raw\ doesn't need to be removed.

Dumps sound extensions and requires sound extensions for loading.

Fixes 8 bit values dumping as signed instead of unsigned.

Fixes SOUND_RANDOMIZE_TYPES enum dumping default value of "volume" instead of "".

@diamante0018
Copy link
Contributor

It appears you are trying to fix white space manually without really understanding what is going on with the formatting check or just unaware about clang-format.

Download the latest llvm release (for windows use the exe installer) https://github.com/llvm/llvm-project

then add it to your PATH then proceed to use clang-format to fix your code like clang-format -i src/patchto folder

@Laupetin
Copy link
Owner

It appears you are trying to fix white space manually without really understanding what is going on with the formatting check or just unaware about clang-format.

Download the latest llvm release (for windows use the exe installer) https://github.com/llvm/llvm-project

then add it to your PATH then proceed to use clang-format to fix your code like clang-format -i src/patchto folder

you do not need to format your code via the clang-format cli. Visual Studio is also capable of formatting via clang-format. You just have to configure it to.
I also have my IDE setup to auto-format any code whenever i save.
That basically makes sure i never have unformatted code.

@Laupetin
Copy link
Owner

A lot of good changes and fixes, thank you :)
I did add a backwards compatible behaviour for guessing file names if no extension is specified, a few enums that some of the strings are based and some code style changes i'd personally do.

I hope that's okay for you, feel free to take a look and check whether that works for you.

@Jbleezy
Copy link
Contributor Author

Jbleezy commented Sep 18, 2024

Okay looks good!

@Laupetin Laupetin merged commit 53cde27 into Laupetin:main Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dumped soundbank asset list does not strip raw/ prefix and does not include file suffix for files
3 participants