-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various soundbank fixes #264
Conversation
It appears you are trying to fix white space manually without really understanding what is going on with the formatting check or just unaware about clang-format. Download the latest llvm release (for windows use the exe installer) https://github.com/llvm/llvm-project then add it to your PATH then proceed to use clang-format to fix your code like |
you do not need to format your code via the clang-format cli. Visual Studio is also capable of formatting via clang-format. You just have to configure it to. |
A lot of good changes and fixes, thank you :) I hope that's okay for you, feel free to take a look and check whether that works for you. |
Okay looks good! |
Closes #138 if
raw\
doesn't need to be removed.Dumps sound extensions and requires sound extensions for loading.
Fixes 8 bit values dumping as signed instead of unsigned.
Fixes
SOUND_RANDOMIZE_TYPES
enum dumping default value of "volume" instead of "".