-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gevent server implementation #1
Conversation
…om threadedhandler and the cherrypyserver.
Brilliant. Did you get a chance to run it against the Autobahn testsuite? I'll review it asap. |
No, where can I find the docs to do that? |
I indicate the couple of steps to follow in the ws4py readme but in a nutshell: Grab a copy at http://www.tavendo.de/autobahn The reports will be generated in the reports directory. Very handy to determine how your code is doing :) |
Okay, I made some updates as you can see to get most of the tests to pass. I'm wondering how many your implementation doesn't pass. In particular, these are failing for me: Test Case 2.5 But they seem more specific to the stream parser than my socket management (ping handling, small fragmented messages). I could be wrong. |
On Mon, Aug 22, 2011 at 8:06 PM, progrium <
Those pass for CherryPy: http://www.defuze.org/oss/ws4py/testreports/servers/cherrypy/ Could there be a different in the way the stream expects to work with
Those fail for me as well.
I'll have to give it a try. Cheers, |
On Mon, Aug 22, 2011 at 8:41 PM, Sylvain Hellegouarch sh@defuze.org wrote:
https://github.com/Lawouach/WebSocket-for-Python/blob/master/ws4py/framing.py#L154
This should pass because of: https://github.com/Lawouach/WebSocket-for-Python/blob/master/ws4py/streaming.py#L190 |
…sgi friendly. now you can use middleware on your upgrade handler
…g tests up to par with the cherrypy implementation
Alright, looks like I'm passing those tests now. I should be failing only the same tests as you. |
Cool. I'll be away from Friday for a couple of weeks and I will not have the
On Tue, Aug 23, 2011 at 8:38 AM, progrium <
|
Excellent. See you on the flip side. -jeff On Mon, Aug 22, 2011 at 11:42 PM, Lawouach
Jeff Lindsay |
Merged :) Well your code is quite self-contained and seems fine (I couldn't test against gevent yet but I trust you). This should make your work a little easier hopefully. |
Address run_forever() terminates too early bug
added a simple WebSocketServer implementation in gevent using code from threadedhandler and the cherrypyserver.