Fixed hangup in Tornado implementation #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in Tornado WebSocket client: it hangs up if server's socket closes before sending handshake response.
Seems like the problem's within this line: https://github.com/Lawouach/WebSocket-for-Python/blob/master/ws4py/client/tornadoclient.py#L29
The solution is to use io.set_close_callback, but i'm not sure if it's right to fire closed callback with code 1006 or should i fire an exception?