-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: unify into single job #10
Conversation
ed6ff03
to
1f99bdc
Compare
c90f181
to
b5b84d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Checks/lints should run before build/release stage
- The Linux runner should maintain its Rust cache through checks/lints.
- Rust cache should not be shared between targets
- name: Rust Cache | ||
uses: Swatinem/rust-cache@v2 | ||
with: | ||
key: ${{ matrix.name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key
is an additional per-job specifier. If you want the cache to be stable across jobs, You need to set shared-key
and perhaps prefix-key
. See https://github.com/Swatinem/rust-cache/tree/master
matrix.name
is not defined here. It needs to share the cache with ubuntu-latest
/x86_64-unknown-linux-gnu
in build-release
.
4457ba0
to
48d76f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caching across check-lint
and build-release
should be fixed in a follow-up PR.
Otherwise LGTM
No description provided.