Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unify into single job #10

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

torkelrogstad
Copy link
Contributor

No description provided.

@torkelrogstad torkelrogstad changed the title ci: unify into single workflow ci: unify into single job Oct 4, 2024
Copy link
Collaborator

@Ash-L2L Ash-L2L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checks/lints should run before build/release stage
  • The Linux runner should maintain its Rust cache through checks/lints.
  • Rust cache should not be shared between targets

.github/workflows/check_lint_build_release.yaml Outdated Show resolved Hide resolved
.github/workflows/check_lint_build_release.yaml Outdated Show resolved Hide resolved
- name: Rust Cache
uses: Swatinem/rust-cache@v2
with:
key: ${{ matrix.name }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key is an additional per-job specifier. If you want the cache to be stable across jobs, You need to set shared-key and perhaps prefix-key. See https://github.com/Swatinem/rust-cache/tree/master

matrix.name is not defined here. It needs to share the cache with ubuntu-latest/x86_64-unknown-linux-gnu in build-release.

.github/workflows/check_lint_build_release.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ash-L2L Ash-L2L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching across check-lint and build-release should be fixed in a follow-up PR.
Otherwise LGTM

@Ash-L2L Ash-L2L merged commit c69cc1a into LayerTwo-Labs:master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants