Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix journalID type (int32 → int64) #84

Merged
merged 1 commit into from
May 13, 2024
Merged

fix journalID type (int32 → int64) #84

merged 1 commit into from
May 13, 2024

Conversation

yuuis
Copy link
Contributor

@yuuis yuuis commented May 13, 2024 •
edited
Loading

@yuuis yuuis requested review from noritama and watarus May 13, 2024 07:19
@yuuis yuuis marked this pull request as ready for review May 13, 2024 07:19
watarus
watarus approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@watarus watarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuuis yuuis self-assigned this May 13, 2024
@yuuis yuuis merged commit 60a76f8 into main May 13, 2024
1 check passed
@yuuis yuuis deleted the fix/deal_id_type branch May 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watarus watarus watarus approved these changes

@noritama noritama Awaiting requested review from noritama

Assignees

@yuuis yuuis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuuis @watarus