Skip to content

feat: Optional async decoupling for secondary writes and reworked E2E metric assertions #261

feat: Optional async decoupling for secondary writes and reworked E2E metric assertions

feat: Optional async decoupling for secondary writes and reworked E2E metric assertions #261

Triggered via pull request October 12, 2024 23:12
Status Failure
Total duration 2m 5s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
Linter: metrics/metrics.go#L187
Error return value is not checked (errcheck)
Linter: metrics/poller.go#L32
use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
Linter: store/secondary.go#L76
use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
Linter: e2e/server_test.go#L355
use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
Linter: metrics/poller.go#L12
exported: type name will be used as metrics.MetricsPoller by other packages, and that stutters; consider calling this Poller (revive)
Linter: metrics/metrics.go#L175
unnecessary trailing newline (whitespace)
Linter: metrics/poller.go#L42
unnecessary trailing newline (whitespace)
Linter: store/router.go#L129
unnecessary leading newline (whitespace)
Linter: store/secondary.go#L117
unnecessary trailing newline (whitespace)
Linter: metrics/metrics.go#L214
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
Linter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/