Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change disperseBlob response timeout to 60sec #105

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

bxue-l2
Copy link
Collaborator

@bxue-l2 bxue-l2 commented Aug 27, 2024

Some users might take longer than 10sec to disperse blobs, when it timed out, the workload on disperser is completed prematurely, see(https://github.com/Layr-Labs/eigenda/blob/master/api/clients/eigenda_client.go#L45) and (https://github.com/Layr-Labs/eigenda/blob/master/disperser/apiserver/server.go#L283) whenever context is timedout

Although processing speed on disperser is less than 500ms, the transmission latency might high

@bxue-l2 bxue-l2 requested review from samlaf, epociask and hopeyen and removed request for samlaf August 27, 2024 18:27
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epociask
Copy link
Collaborator

Actually lets also update the default values in the README table a well 🙏🏻

@bxue-l2 bxue-l2 merged commit 83811ac into main Aug 28, 2024
7 checks passed
@bxue-l2 bxue-l2 deleted the increase-default-timeout-for-proxy branch August 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants