Skip to content

Commit

Permalink
style: updated TODO comment to change CustomQuorumIDs type to core.Qu…
Browse files Browse the repository at this point in the history
…orumID eventually
  • Loading branch information
samlaf committed Oct 18, 2024
1 parent bb1eb0e commit 839ffbb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions api/clients/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type EigenDAClientConfig struct {
WaitForFinalization bool

// The quorum IDs to write blobs to using this client. Should not include default quorums 0 or 1.
// TODO: should we change this to core.QuorumID instead? https://github.com/Layr-Labs/eigenda/blob/style--improve-api-clients-comments/core/data.go#L18
CustomQuorumIDs []uint

// Signer private key in hex encoded format. This key is currently purely used for authn/authz on the disperser.
Expand Down
1 change: 0 additions & 1 deletion api/clients/eigenda_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ func (m EigenDAClient) putBlob(ctx context.Context, rawData []byte, resultChan c
return
}

// TODO: should we just use uint8s directly in the config?
customQuorumNumbers := make([]uint8, len(m.Config.CustomQuorumIDs))
for i, e := range m.Config.CustomQuorumIDs {
customQuorumNumbers[i] = uint8(e)
Expand Down

0 comments on commit 839ffbb

Please sign in to comment.