Add dispersing transistion check #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Sep 1, 2024
| s.logger.Error("error getting blob metadata while marking blobDispersing", "err", err) | ||
| return err | ||
| } | ||
| alreadyConfirmed, _ := refreshedMetadata.IsConfirmed() |
There was a problem hiding this comment.
What about just checking if the status is PROCESSING? That's the only valid predecessor for DISPERSING.
jianoaix
approved these changes
Sep 3, 2024
| return err | ||
| } | ||
| alreadyConfirmed, _ := refreshedMetadata.IsConfirmed() | ||
| if alreadyConfirmed { |
There was a problem hiding this comment.
This part seems not needed anymore
jianoaix
reviewed
Sep 3, 2024
| @@ -158,6 +162,23 @@ func (s *SharedBlobStore) MarkBlobConfirmed(ctx context.Context, existingMetadat | |||
| } | |||
|
|
|||
| func (s *SharedBlobStore) MarkBlobDispersing(ctx context.Context, metadataKey disperser.BlobKey) error { | |||
| refreshedMetadata, err := s.GetBlobMetadata(ctx, metadataKey) | |||
There was a problem hiding this comment.
Have you checked the conditional update which may save one RPC call: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.ConditionExpressions.html#Expressions.ConditionExpressions.SimpleComparisons
|
Looks good. Should we add a similar check for the |
jianoaix
pushed a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Bowen Xue <ubuntu@ip-172-31-91-211.ec2.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks in shared_storage.go to ensure, the state of a blob never transit from confirmed to dispersing