Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'make protoc' now utilizes docker workflow by default. #748

Merged
merged 3 commits into from
Sep 20, 2024
Merged

'make protoc' now utilizes docker workflow by default. #748

merged 3 commits into from
Sep 20, 2024

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Sep 5, 2024 •
edited
Loading

Why are these changes needed?

This change makes make protoc use the dockerized workflow by default. make protoc-local can be used for the legacy build workflow that does not utilize docker.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Hand tests (CI use of this workflow comes in following PR)
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@cody-littley
'make protoc' now utilizes docker workflow by default.
008af92 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Cleanup.
846210c 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Fix clean.
1fa215a 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
hopeyen
hopeyen approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cody-littley cody-littley merged commit 45f6941 into Layr-Labs:master Sep 20, 2024
6 checks passed
@cody-littley cody-littley deleted the pbuf-docker-by-default branch September 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

@jianoaix jianoaix Awaiting requested review from jianoaix

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cody-littley @hopeyen