Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: eigenda client confirmation depth #819

Closed
wants to merge 12 commits into from
Closed

Feat: eigenda client confirmation depth #819

wants to merge 12 commits into from

Commits on Oct 2, 2024

  1. style: improve api/clients comments

    @samlaf
    samlaf committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    12510c6 View commit details
    Browse the repository at this point in the history

  2. refactor: remove eigendaClient GetCodec() dependency 

    method is now no longer used anymore, and could be deprecated
    @samlaf
    samlaf committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6f3c6ee View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. docs: add comment explaining why blobEncodingVersion stored in [1] in… 

    …stead of [0]
    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bb1eb0e View commit details
    Browse the repository at this point in the history

  2. style: updated TODO comment to change CustomQuorumIDs type to core.Qu… 

    …orumID eventually
    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    839ffbb View commit details
    Browse the repository at this point in the history

  3. style: fix PutBlob's docstring comment wrt finalization status

    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4c8a2d7 View commit details
    Browse the repository at this point in the history

  4. style: made more accurate comment about field element value range

    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6b78c52 View commit details
    Browse the repository at this point in the history

  5. style: update outdated comment about adding idempotency key 

    only need tracing-id key now since v2 will do idempotency using blobHeader
Also realized using same key for idempotency and tracing doesn't make sense, since one might want different requests to be traced idependently but use the same idempotency key
    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1364bb1 View commit details
    Browse the repository at this point in the history

  6. chore: make protoc

    @samlaf
    samlaf committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7b600a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. feat: add confirmation depth flag to eigenda-client

    @samlaf
    samlaf committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9853678 View commit details
    Browse the repository at this point in the history

  2. style: fix lint problem (comparison to bool constant)

    @samlaf
    samlaf committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    492fdbb View commit details
    Browse the repository at this point in the history

  3. docs: better documentation for EigenDAClientConfig.WaitForConfirmatio… 

    …nDepth
    @samlaf
    samlaf committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    72ebbd3 View commit details
    Browse the repository at this point in the history

  4. tests: add eda client e2e test for waitForConfirmationDepth feature

    @samlaf
    samlaf committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    867df5a View commit details
    Browse the repository at this point in the history