Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add claimer address flag when claimer is not earner for claim method #201

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: add claimer address flag when claimer is not earner for claim method #201

merged 1 commit into from
Aug 27, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Aug 27, 2024 •
edited
Loading

Fixes # .

What Changed?

  • There is a bug where we can't set claimer address in non broadcast mode when earner has set a new claimer address. This PR adds that and fixes it.
  • In the broadcast mode, it depends on the signer so that path was working
  • Some debug logging improvements

@shrimalmadhur shrimalmadhur changed the title fix: add claimer flag when claimer is not earner for claim method fix: add claimer address flag when claimer is not earner for claim method Aug 27, 2024
@shrimalmadhur shrimalmadhur merged commit 2b1c6e6 into master Aug 27, 2024
8 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/fix-gas-for-smart-contract branch August 27, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shrimalmadhur