Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons horizontal size was hardcoded in JS (fix #180) #181

Merged
merged 1 commit into from
Sep 5, 2013

Conversation

Grsmto
Copy link

@Grsmto Grsmto commented Sep 4, 2013

It uses 'display: inline-block' css property so it should not work on IE6/7 (as I didn't tested it I couldn't provide a conditional alternative, i'll do it later if pr is ok).
So, buttons can now contain any text length (for i18n) without breaking.

@jacobtoye
Copy link
Member

Awesome thanks :) I'll add a inline-block fix to the IE stylesheet.

jacobtoye added a commit that referenced this pull request Sep 5, 2013
Buttons horizontal size was hardcoded in JS (fix #180)
@jacobtoye jacobtoye merged commit 39fce3c into Leaflet:master Sep 5, 2013
jacobtoye added a commit that referenced this pull request Sep 5, 2013
@leplatrem
Copy link
Contributor

GG @Grsmto ;)

Just one line of dead code left :

buttonWidth = 50,

@Grsmto Grsmto deleted the buttons-size-i18n branch September 5, 2013 08:24
jacobtoye added a commit that referenced this pull request Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants