Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically set actions position. #240

Closed
wants to merge 3 commits into from

Conversation

DevinClark
Copy link
Contributor

No description provided.

@DevinClark
Copy link
Contributor Author

Thoughts, @jacobtoye?

@jacobtoye
Copy link
Member

Sorry I hadn't yet gotten to this one.

Looks OK, I'll give it a test today. Will need to check to see if it support IE7, from memory I think it has problems with offsetTop.

Also could you please revert the second commit. You don't need to build the library.

@DevinClark
Copy link
Contributor Author

No problems using IE11 in IE7 emulation mode. I don't have a native IE7 browser to test in because we support IE9+.

@jacobtoye
Copy link
Member

@DevinClark thanks for this, I've cherry picked your commit. 762e872

@jacobtoye jacobtoye closed this Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants