Improve polyline/polygon drawing by accepting some motion on click #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this looks pretty cool! Could you pull in the latest changes to get this merge lined up :) |
…ittle bit of mouse motion. The problem is that Leaflet.draw will miss most of the points if one quickly (or even not terribly quickly) tries to draw a shape such as a polygon. This is because clicking using a physical mounse typically introduces a little bit of motion to the on-screen mouse cursor. Such clicks will be perceived as a map move event, not a draw click. The solution is to hook `mousedown` rather than `click`, and track the distance of the motion when `mouseup` is received.
|
Done — sorry, forgot to fetch before I did the PR. |
|
There is a chance this PR will allow drawing on mobile devices (namely on Nokia Browser). |
jacobtoye
added a commit
that referenced
this pull request
Jan 13, 2014
Improve polyline/polygon drawing by accepting some motion on click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves polyline/polygon drawing by accepting clicks that involve a little bit of mouse motion.
The problem is that Leaflet.draw will miss most of the points if one quickly (or even not terribly quickly) tries to draw a shape such as a polygon. This is because clicking using a physical mounse typically introduces a little bit of motion to the on-screen mouse cursor. Such clicks will be perceived as a map move event, not a draw click.
The solution is to hook
mousedownrather thanclick, and track the distance of the motion whenmouseupis received.