Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer #1114

Closed
DanielTate opened this issue Nov 2, 2012 · 9 comments · Fixed by #1117
Closed

Internet Explorer #1114

DanielTate opened this issue Nov 2, 2012 · 9 comments · Fixed by #1117
Assignees
Labels
Milestone

Comments

@DanielTate
Copy link

Internet explorer running the Browser mode IE7 doesn't render correctly.
I apologize if this issue has been covered in a similar Windows Phone Issue.

@danzel
Copy link
Member

danzel commented Nov 2, 2012

IE7+ on the desktop is fine. (IE10 in win phone 8 should be fine too)
What device are you talking about?

@DanielTate
Copy link
Author

I am running Windows 7 64bit.
I have tested in both IE932bit and 64bit both emulating IE7 with the "browser mode" developer tool.
Both with the same result.
If you look at the attached image you should notice the triangle pointer that should be attached to the content box is not.
http://s11.postimage.org/3purnw3cz/leaflet_pointer.png

@mourner
Copy link
Member

mourner commented Nov 2, 2012

Try running it in an actual IE7 instead of IE9 browser mode.

@mourner mourner closed this as completed Nov 2, 2012
@danzel
Copy link
Member

danzel commented Nov 2, 2012

It looks like that in real IE7 too. It's been like that for as long as I can remember but I haven't cared to fix it.

It happens as IE7 is doing something weird with leaflet-popup-content-wrapper margins.
The top/bottom ones are applied but don't make the parent box any bigger.
Replacing them with padding seems to fix it I think.

@danzel danzel reopened this Nov 2, 2012
@mourner
Copy link
Member

mourner commented Nov 2, 2012

Hmm, quite weird, it was always OK for me on IE7 on IETester. I think it's worth setting up a virtual machine to figure it out correctly.

@danzel
Copy link
Member

danzel commented Nov 2, 2012

I have all the VMs set up at work, just remoting and doing some testing with padding

@mourner
Copy link
Member

mourner commented Nov 2, 2012

Probably a hasLayout issue, need to try adding something like zoom: 1 or height: 1% to .leaflet-popup-content-wrapper in leaflet-ie.css.

@ghost ghost assigned mourner Nov 2, 2012
@danzel
Copy link
Member

danzel commented Nov 2, 2012

yep, you've got it. zoom on wrapper fixes, preparing PR

@ghost ghost assigned danzel Nov 2, 2012
@mourner
Copy link
Member

mourner commented Nov 2, 2012

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants