Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom function targeting is off (Leaflet 0.7 release, Chrome 32.0.1700.14m Aura) #2352

Closed
mindplay-dk opened this issue Jan 7, 2014 · 11 comments
Closed

Zoom function targeting is off (Leaflet 0.7 release, Chrome 32.0.1700.14m Aura) #2352

mindplay-dk opened this issue Jan 7, 2014 · 11 comments
Assignees
@mourner
Labels
blocker Critical issue or PR that must be resolved before the next release
Milestone
0.7.*

Comments

@mindplay-dk
Copy link

The zoom function for some reason seems to be broken with the last release of Chrome - it isn't calculating the center of the zoom operation correctly, whether you use the mouse-wheel or double click, the point it's zooming to appears to be offset relative to the scroll offset of the page.

In case this is difficult to understand, I posted a video demonstrating the issue - I used some free tool to record this, and the frame rate isn't great, but pay attention to where the mouse is, and where the zoom operation goes to. As you can see, it works until I start dragging the scroll bar - in the video I'm dragging it a little bit first, to show that the vertical zoom target goes off by just a little bit, and then by a lot.

If the page is scrolled very far, the zoom operation goes completely ballistic (you don't see that in the video) and often zooms all the way out to maximum zoom with a single touch of the mouse-wheel.

This bug is currently repeatable on leafletjs.com home page (as you saw) and occurs on a site I am currently working on (locally).
@mindplay-dk
Copy link
Author

Looks like a bug in Chrome switches to the Aura release from the stable/production release automatically!

I have tried to uninstall and the "stable" installer just keeps re-installing the Aura release.

Well, that's my problem - but you may want to report the issue I described to the Chrome maintainers, as it looks like they did introduce a bug (?) in the Chrome beta-release; you may want to be proactive and bring this to their attention before this bug (if it is a bug in Chrome) makes it into the stable/production release...

@mindplay-dk
Copy link
Author

(also, it looks like others are affected and were - or will be - quietly "upgraded" from the stable release to this buggy beta-release, so this may be affecting Leaflet users now already.)

@danzel
Copy link
Member

danzel commented Jan 9, 2014

mourner rewrote some code that may affect this in master.
If you still have aurora could you please check it?

I've just reinstalled my PC and am still installing my apps again.

@mourner
Copy link
Member

mourner commented Jan 9, 2014

Probably nothing to worry about since Stable and Canary work correctly, and bleeding edge bugs come and go. Will reopen if reproducible on a closer release.

@mourner mourner closed this as completed Jan 9, 2014
@mindplay-dk
Copy link
Author

If you still have aurora could you please check it?

Nope, it's gone - for good... as much as I love supporting open source projects, Chrome beta has cost me too many hours of random issues and debugging phantom bugs, so I'm now running the stable release only...

@danzel
Copy link
Member

danzel commented Jan 10, 2014

lol, good plan :)

@mourner mourner reopened this Jan 15, 2014
@mourner
Copy link
Member

mourner commented Jan 15, 2014

Probably nothing to worry about since Stable and Canary work correctly, and bleeding edge bugs come and go

Shit, now the bug is in stable (while Canary still works), lol. Have to promise myself to always check beta versions. :( Will release a hotfix 0.7.2 tomorrow.

@ghost ghost assigned mourner Jan 15, 2014
@danzel danzel mentioned this issue Jan 15, 2014
Closed
mourner added a commit that referenced this issue Jan 15, 2014
@mourner
fix scrolled page mouse events in Chrome 32, close #2352
950034e
@mourner mourner closed this as completed Jan 15, 2014
@mourner mourner mentioned this issue Jan 17, 2014
Closed
@mourner
Copy link
Member

mourner commented Jan 17, 2014

Patched version here: http://leaflet-cdn.s3.amazonaws.com/build/leaflet-stable.zip
Releasing as 0.7.2 now.

mourner added a commit that referenced this issue Jan 17, 2014
@mourner
Merge branch 'stable' into gh-pages
f42d609 
* stable:
  update stable branch changelog for 0.7.2 [skip ci]
  bump version to 0.7.2
  fix scrolled page mouse events in Chrome 32, close #2352
  fix rounding bug with unconventional tile sizes, close #2288
  Use _getTileSize() instead of using options.tileSize directly
@gabrielhase gabrielhase mentioned this issue Jan 18, 2014
Merged
@mourner mourner mentioned this issue Jan 20, 2014
Closed
@grafana-dee grafana-dee mentioned this issue Jan 24, 2014
Merged
@chrisstoll
Copy link

I've replaced leaflet with the latest 0.7.2 version, but I'm still getting the buggy behavior in Chrome 32.0.1700.77 in Ubuntu. Have verified that it works fine in FireFox. A map initialized at zoom level 5 centered over SF, CA, jumps over to the east coast when zoomed, whereas in FF it stays centered around the mouse.

@mourner
Copy link
Member

mourner commented Feb 24, 2014

Are you sure? Can you set up a JSFiddle?

@chrisstoll
Copy link

Forgive me, it appears ThreeJS was convoluting the issue. Working great, thanks for the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mourner mourner

Labels
blocker Critical issue or PR that must be resolved before the next release
Projects
None yet
Milestone
0.7.*
Development

No branches or pull requests
4 participants
@mourner @mindplay-dk @danzel @chrisstoll