Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing this._times.length undefined in Map.Drag.js, fixes #4311 #4324

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

LucasMouraDeOliveira
Copy link
Contributor

No description provided.

@@ -77,10 +79,6 @@ L.Map.Drag = L.Handler.extend({
.fire('movestart')
.fire('dragstart');

if (map.options.inertia) {
this._positions = [];
this._times = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the initialization in _onDragStart? If inertia is enabled, we want to forget the speed of the previous drag(s) whenever a new drag is started; so we want to keep this bit of code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, i'm updating it right now.

@IvanSanchez
Copy link
Member

Looks good now, but please squash your commits into one. For very small features/bugfixes such as this one we prefer to have just one commit.

Update Map.Drag.js

Update Map.Drag.js
@IvanSanchez
Copy link
Member

👍

IvanSanchez added a commit that referenced this pull request Mar 15, 2016
fixing this._times.length undefined in Map.Drag.js, fixes #4311
@IvanSanchez IvanSanchez merged commit 0ea9832 into Leaflet:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants