Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make L.Handler.enable/disable return this #4708

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Conversation

yohanboniface
Copy link
Member

Those are methods used very often, this can save us a lot of
useless lines.

this.handling.enable().doSomething();

instead of

this.handling.enable()
this.handling.doSomething()

Just like we have for addTo and such.

@IvanSanchez
Copy link
Member

@yohanboniface Docstrings should reflect the return value too.

@yohanboniface yohanboniface force-pushed the handler-return-this branch from fd35680 to 64a1ee6 Compare July 5, 2016 08:18
Those are methods used very often, this can save us a lot of
useless lines.
@yohanboniface
Copy link
Member Author

Good catch :)
Fixed!

@IvanSanchez IvanSanchez merged commit c263f2d into master Jul 5, 2016
@yohanboniface yohanboniface deleted the handler-return-this branch August 8, 2016 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants