Release the pressed ActionData when it isn't being updated

[Shute052]

Objective

Fixes #471.

Solution

The actual issue lies in the incorrect updating of ActionState because it is now updated through a HashMap instead of a Vec, but the clashed ActionData has been removed (since #450).

Relevant Code

// Handle clashes before #450
pub fn handle_clashes(
    &self,
    action_data: &mut [ActionData],
    input_streams: &InputStreams,
    clash_strategy: ClashStrategy,
) {
    for clash in self.get_clashes(action_data, input_streams) {
        // Remove the action in the pair that was overruled, if any
        if let Some(culled_action) = resolve_clash(&clash, clash_strategy, input_streams) {
            action_data[culled_action.index()] = ActionData::default();
        }
    }
}
// Update ActionData before #450
pub fn update(&mut self, action_data: Vec<ActionData>) {
    assert_eq!(action_data.len(), A::n_variants());

    for (i, action) in A::variants().enumerate() {
        match action_data[i].state {
            ButtonState::JustPressed => self.press(&action),
            ButtonState::Pressed => self.press(&action),
            ButtonState::JustReleased => self.release(&action),
            ButtonState::Released => self.release(&action),
        }

        self.action_data[i].axis_pair = action_data[i].axis_pair;
        self.action_data[i].value = action_data[i].value;
    }
}

// Handle clashes after #450
pub fn handle_clashes(
    &self,
    action_data: &mut HashMap<A, ActionData>,
    input_streams: &InputStreams,
    clash_strategy: ClashStrategy,
) {
    for clash in self.get_clashes(action_data, input_streams) {
        // Remove the action in the pair that was overruled, if any
        if let Some(culled_action) = resolve_clash(&clash, clash_strategy, input_streams) {
            action_data.remove(&culled_action);
        }
    }
}
// Update ActionData after #450
pub fn update(&mut self, action_data: HashMap<A, ActionData>) {
    for (action, action_datum) in action_data {
        match self.action_data.entry(action) {
            Entry::Occupied(occupied_entry) => {
                let entry = occupied_entry.into_mut();

                match action_datum.state {
                    ButtonState::JustPressed => entry.state.press(),
                    ButtonState::Pressed => entry.state.press(),
                    ButtonState::JustReleased => entry.state.release(),
                    ButtonState::Released => entry.state.release(),
                }

                entry.axis_pair = action_datum.axis_pair;
                entry.value = action_datum.value;
            }
            Entry::Vacant(empty_entry) => {
                empty_entry.insert(action_datum.clone());
            }
        }
    }
}

[alice-i-cecile]

Can you please add a regression test? Change itself looks great though.

[Shute052]

Can you please add a regression test? Change itself looks great though.你能添加一个回归测试吗？变化本身看起来很棒。

I'm on board, and updated the description of the real issues after investigation.

[porkbrain]

Thank you for tackling this 🫀

[Shute052]

If I've got it right, this test should work.