Add more comments and make some small refactors and changes to PaigeTarjan folder #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary set of b.ptr.
Set b.ptr directly instead of also incrementing ptr. Since ptr is a local variable, this behavior is unnecessary.
|
Thanks for the PR. A reduction in code-copy is always appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract repeated methods in PaigeTarjanInitializers. (These could also be applied to a lesser extent in OneSEVPAMinimizer.)
Add comments to PaigeTarjanInitializers, PaigeTarjan, and Block.
In PaigeTarjan: remove unnecessary set of b.ptr (which was set as a post-condition of split). Remove unnecessary increment of local variable.