-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Issue #74 - [DOC] add typings to functions #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Nice work! 🚀 Be great to finally have full typing!
👏 praise: Great and clear PR description as well! Really helped with context for reviewing!
🎯 suggestion (non-blocking): maybe if there's an appetite for this we can add mypy --strict
to the pipeline to ensure we maintain our current typing after all this effort! This could maybe be a follow up PR if the mainters are happy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Couple of notes on the release process and Codacy warnings.
cb6a114
to
e6d3812
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🦜
1ff90b7
to
aed11d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
aed11d9
to
6cfe64a
Compare
Problem Statement
Open Issues this addresses: https://github.com/Learnosity/learnosity-sdk-python/issues/74
The functions used in this package do not have any type hints included. This PR addresses that.
PR Actions
closes #74
What was done
How was this change tested
mypy --strict learnosity_sdk
to verify all type hints and issuesNotes and TODOs
make dist
completed successfully