Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Resolve deprecation warning for datetime.datetime.utcnow #94

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

ferdia-sopermaccafraidh-lrn
Copy link
Contributor

@ferdia-sopermaccafraidh-lrn ferdia-sopermaccafraidh-lrn commented Nov 1, 2024

Overview

Resolves deprecation warning from tests due to now deprecated usage of utcnow.

tests/integration/test_dataapi.py: 10 warnings
tests/unit/test_dataapi.py: 8 warnings
  /Volumes/lde-code/learnosity-sdk-python/learnosity_sdk/request/init.py:15: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    now = datetime.datetime.utcnow()

Reference

Copy link
Contributor

@michael-linnane-lrn michael-linnane-lrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ferdia-sopermaccafraidh-lrn ferdia-sopermaccafraidh-lrn merged commit 0e43bf5 into master Nov 1, 2024
6 checks passed
@ferdia-sopermaccafraidh-lrn ferdia-sopermaccafraidh-lrn deleted the resolve-utc-deprecation-warning branch November 1, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants