Fix accidental PVC expunge when used icw cloudstack-csi-driver #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If csMachine.Spec.DiskOffering is nil, skip looking up data volumes attached to VM for expunging If csMachine.Spec.DiskOffering is not nil, only add data volumes for expunging that are named 'DATA-<something>'
This reverts commit 1146199.
This avoids having a monolithic hack/tools/go.mod file and fixes problems with kustomize v4.5.7 failing to build w/ CAPI 1.5.x
FarnazBGH
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#16
Description of changes:
If csMachine.Spec.DiskOffering is nil, skip looking up data volumes attached to VM for expunging
If csMachine.Spec.DiskOffering is not nil, only add data volumes for expunging that are named 'DATA-'
pointer.To, since the replacement packagek8s.io/utils/pointerrequires a newer version ofk8s.io/utilswhich pulls in a version ofk8s.io/kube-openapithat is incompatible with client-go 0.27.xTesting performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.