-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and remove unused ones. Pin git dependencies. #169
Conversation
Got warning on Android:
However it compiled and installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done smoke test on Windows, Android, Linux, Mac. Seems it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever possible (i.e. in non-3rd-party repos) it'd be way better to actually tag things (then used named tags here).
file_picker: ^4.5.0 | ||
intro_slider: | ||
git: | ||
url: https://github.com/shareef-dweikat/flutter-intro-slider | ||
ref: a9bb492412c68419900750fe12e0487e3a1168fb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do releases of these? or at least named tags (since they appear to be repos "we" control?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's reasonable, I agree, CC @shareef-dweikat
I put the hashes here as an improvement over nothing at all. I guess also tags may be overwritten to point to different hashes. In that sense, maybe hashes are more reproducible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess depends what the use-case is ... for reproducibility I suppose the hash is better here (coming from python-land, you'd pin against "the hash of the 1.2.3 release on PyPI" normally).
Even if this uses the hash it could still be beneficial to have like "22.9.1" (date-based) tags to help the humans but I'll leave that to people actually doing this ;) and also I don't know flutter ecosystem at all
Merging to allow testing early while For |
OP#2200
Code Review Checklist