Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github links and update plugin #180

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Fix github links and update plugin #180

merged 4 commits into from
Sep 27, 2022

Conversation

ewanas
Copy link
Contributor

@ewanas ewanas commented Sep 27, 2022


Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@ewanas ewanas changed the title Point links within a release to the released versions Fix github links and update plugin Sep 27, 2022
Copy link
Contributor

@donpui donpui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With links we behave in such way, that any version of app will always point FAQ, Privacy policy to main branch, that we would not need update it without releasing new app version.

Regarding terms, they will point to specific branch/tag version file. This means, with every terms changes, we will need to release new app version to get consent for terms.

@ewanas ewanas merged commit 35435ff into main Sep 27, 2022
@ewanas ewanas deleted the versioned-links branch September 27, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants