Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling lint usage and fixing static analysis error #218

Merged
merged 11 commits into from
Jan 19, 2023
Merged

Enabling lint usage and fixing static analysis error #218

merged 11 commits into from
Jan 19, 2023

Conversation

donpui
Copy link
Contributor

@donpui donpui commented Jan 18, 2023

Enabling lint usage and fixing static analysis error. Issue: #217

Also one fix necessary in dart_wormhole_william

I have some doubts about immutable ignore cases, maybe here requires are little bit more looking


Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

ewanas
ewanas previously approved these changes Jan 19, 2023
@donpui donpui merged commit 3e8f6d9 into main Jan 19, 2023
@donpui donpui deleted the add-lint branch January 19, 2023 14:18
@donpui donpui mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants