Skip to content

Commit

Permalink
Merge pull request #32 from LedgerHQ/develop
Browse files Browse the repository at this point in the history
Merge to master
  • Loading branch information
cedelavergne-ledger authored Sep 20, 2024
2 parents 3de13c3 + a792352 commit 122d0a0
Show file tree
Hide file tree
Showing 229 changed files with 16 additions and 3 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/build_and_functional_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ name: Build and run functional tests using ragger through reusable workflow

on:
workflow_dispatch:
inputs:
golden_run:
type: choice
required: true
default: 'Raise an error (default)'
description: CI behavior if the test snapshots are different than expected.
options:
- 'Raise an error (default)'
- 'Open a PR'
push:
branches:
- master
Expand All @@ -29,3 +38,4 @@ jobs:
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
with:
download_app_binaries_artifact: compiled_app_binaries
regenerate_snapshots: ${{ inputs.golden_run == 'Open a PR' }}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 6 additions & 3 deletions tests/functional/test_sign_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def test_sign_transaction_newaccount_accepted(test_name, firmware, backend, navi
messages = split_message(payload, MAX_CHUNK_SIZE)
assert len(messages) == 2

if firmware.device.startswith("nano"):
if firmware.is_nano:
instructions = get_nano_review_instructions(2) + get_nano_review_instructions(7)
else:
instructions = [NavInsID.USE_CASE_REVIEW_TAP] * 5
Expand All @@ -99,10 +99,13 @@ def test_sign_transaction_newaccount_accepted(test_name, firmware, backend, navi
test_name + "/part1",
instructions)

if firmware.device.startswith("nano"):
if firmware.is_nano:
instructions = get_nano_review_instructions(6) + get_nano_review_instructions(8)
else:
instructions = [NavInsID.USE_CASE_REVIEW_TAP] * 6
if firmware == Firmware.FLEX:
instructions = [NavInsID.USE_CASE_REVIEW_TAP] * 6
else:
instructions = [NavInsID.USE_CASE_REVIEW_TAP] * 5
instructions.append(NavInsID.USE_CASE_REVIEW_CONFIRM)
instructions.append(NavInsID.USE_CASE_STATUS_DISMISS)
with client.send_async_sign_message_full(messages[1], False):
Expand Down

0 comments on commit 122d0a0

Please sign in to comment.