Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2CA-1681: Port Flex #28

Merged
merged 13 commits into from
Jun 19, 2024
Merged

B2CA-1681: Port Flex #28

merged 13 commits into from
Jun 19, 2024

Conversation

cedelavergne-ledger
Copy link

@cedelavergne-ledger cedelavergne-ledger commented Jun 14, 2024 •
edited
Loading

This PR update the Apps to prepare and then add Flex support:

  • Update version to 1.5.0
  • Fix deprecated warnings
  • Port to Standard App Makefile
  • Port to lib_standard_app
  • Replace THROW by return
  • Add linters config files
  • Fix linter comments
  • Port NBGLv2, and adapt tests accordingly
  • Update Stax snapshots for NBGLv2
  • Add Flex support

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

XavierChapron
XavierChapron reviewed Jun 14, 2024
View reviewed changes
src/eos_stream.c Outdated Show resolved Hide resolved
@XavierChapron
Copy link

Also changes from here could be interesting https://github.com/LedgerHQ/app-eos/pull/25/files

@cedelavergne-ledger cedelavergne-ledger mentioned this pull request Jun 17, 2024
Closed
@cedelavergne-ledger
Copy link
Author

Also changes from here could be interesting https://github.com/LedgerHQ/app-eos/pull/25/files

Yes, I have based my modifications on this PR, taking into accout more recent NBGL APIs 😉

tdejoigny-ledger
tdejoigny-ledger reviewed Jun 19, 2024
View reviewed changes
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good practice for next time. Open a dedicated PR for linting, it will ease the delta review.

README.md Show resolved Hide resolved
src/ui_nbgl.c Outdated Show resolved Hide resolved
tests/functional/usage.md Outdated Show resolved Hide resolved
tests/functional/usage.md Outdated Show resolved Hide resolved
tests/functional/usage.md Outdated Show resolved Hide resolved
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1681_Port-Flex branch 2 times, most recently from b54703d to 076588e Compare June 19, 2024 11:45
@cedelavergne-ledger cedelavergne-ledger merged commit a7d3ee2 into develop Jun 19, 2024
41 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1681_Port-Flex branch June 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChapron XavierChapron XavierChapron left review comments

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

@agrojean-ledger agrojean-ledger Awaiting requested review from agrojean-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedelavergne-ledger @XavierChapron @tdejoigny-ledger