B2CA-1150: FAT porting flow #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cedelavergne-ledger
force-pushed
the
FAT_porting-flow
branch
14 times, most recently
from
b2d8e3b
to
ebe8f78
Compare
cedelavergne-ledger
requested review from
xchapron-ledger,
agrojean-ledger and
tdejoigny-ledger
cedelavergne-ledger
force-pushed
the
FAT_porting-flow
branch
2 times, most recently
from
c4245cc
to
8cec528
Compare
- Based on boilerplate example - Implementing tests like the legacy js code from Zondax
cedelavergne-ledger
force-pushed
the
FAT_porting-flow
branch
2 times, most recently
from
1166954
to
2b5042f
Compare
- Move src from app to the repo root - Move glyphs from app to the repo root - Move app icons to a new icons directory at the repo root - Remove useless app directory - Adapt Makefile accordingly, removing usage of dockerized Makefile from zxlib - Update .gitignore file accordingly - Update Ledger Version field for specific APDU
Rename few files to avoid conflicts during compilation
- Remove legacy test files and config - Update git submodule files - Remove useless deps PicoSHA2
- No Stax support for now - Handle submdules - Update codespell version, and exclude few files - Check if unit-tests directory exists before execution
cedelavergne-ledger
force-pushed
the
FAT_porting-flow
branch
2 times, most recently
from
1ae1efe
to
a7a35ff
Compare
- Fix mypy - Fix spelling - Remove icons alpha channel - Fix clang-format - Fix CodeQL
- Update APDU Specification document - Update README document, based on Boilerplate example - Add doxygen config file
cedelavergne-ledger
force-pushed
the
FAT_porting-flow
branch
from
a7a35ff
to
9031087
Compare
xchapron-ledger
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the repository:
boilerplateraggerzxliband add Stax supportFrom the ticket https://ledgerhq.atlassian.net/browse/B2CA-1150
raggertests implementationapplication_clientmodule and application dedicated testsUpdate build system
srcandglyphsfromappto the repository rooticonsdirectory at the repository rootMakefileto the up-to-date format.gitignorefile accordinglyledger-app-dev-toolsdocker and VSCode pluginUpdate
zxlibzxlibas a sub-module, no more hardcoded copy without referencezxlib(current version is 19.8.2)Add Stax support
Add Ledger CI workflows
doxygenconfig file and.clang-formatrules fileboilerplateCI and adapt them (naming, exceptions, actions version change...)Update the documents following the different modifications
APDU SpecificationdocumentREADMEdocument, according toboilerplateexampledoxygenconfig