Large flow app update #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we will need to make a lot of changes there. Replace zxlib logging mechanism based on debugging with PRINTF macro.
Ported from old c++ tests to cmocka
No tests for message signing, but everything else works as before.
To remove CodeQL warnings.
First transaction test runs, needs to fix other tests Some manifest tests may not work at all if script hashes are not in merkle tree
To test the app that it discovers errors in the proof by a malicious client
Now supports key value reversal. Displays value JSON.
To fix crashes on Speculos.
Audit findings
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
tdejoigny-ledger
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developThis PR contains a lot improvements most of them implemented almost two years ago. As Ledger made significant changes o he app while our development was stopped, our apps diverged significantly. We decided o rebase our work from https://github.com/onflow/ledger-app-flow on top of your develop branch, keeping almost all changes you made.
Main new features: