Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cargo-ledger and ledgerwallet versions. Add support for Flex and… #125

Merged
merged 1 commit into from
May 27, 2024
Merged

Bump cargo-ledger and ledgerwallet versions. Add support for Flex and… #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.24.2] - 2024-05-27

### Changed
- full: Bump cargo-ledger version to 1.4.0 and ledgerwallet version to 0.5.0.

## [3.24.1] - 2024-05-24

### Changed
Expand Down
4 changes: 2 additions & 2 deletions full/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@
libffi-dev

# Install ledgerctl, which is used by cargo ledger for loading or dumping an APDU app file.
RUN pip3 install ledgerwallet==0.4.0
RUN pip3 install ledgerwallet==0.5.0

Check warning on line 40 in full/Dockerfile

View check run for this annotation

Ledger Wiz (CSPM & secret detection) / Wiz IaC Scanner

Pip install keeping cached packages 

Rule ID: 825ae084-a21d-4595-9378-0b5b9edbc4d1
Severity: Medium
Resource: FROM={{ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest}}.{{pip3 install ledgerwallet==0.5.0}}

When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller
Raw output 
Expected: The '--no-cache-dir' flag should be set when running 'pip/pip3 install'
Found: The '--no-cache-dir' flag isn't set when running 'pip/pip3 install'

# Cleanup, remove packages that aren't needed anymore
RUN apk del python_build_deps

# Add cargo ledger
RUN cargo +$RUST_STABLE_VERSION install --version 1.3.0 cargo-ledger
RUN cargo +$RUST_STABLE_VERSION install --version 1.4.0 cargo-ledger

# Setup cargo ledger (install JSON target files and custom link script) for nightly
RUN cargo +$RUST_NIGHTLY_VERSION ledger setup
Expand Down
Loading