Use "nicer" cfgs #38
Merged
Use "nicer" cfgs #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hacking in the specific device in the `build.rs`, which doesn't work for downstream packages, specify it as the "os" in the target json. Also specify "bolos" as a `target_family` to make a catch-all `cfg` for any Ledger device easy too.
Ericson2314
added a commit
to alamgu/ledger-nanos-sdk
that referenced
this pull request
Aug 25, 2022
The first change is to parse once, and then use an enum for the device. This is hopefully a straightforward improvement. The second change is to case on the OS name (leveraging LedgerHQ#38) instead of the target name. The target "name" isn't so structured, and it is unclear to what extent it should be anm exposed part of the target. (See rust-lang/rust#98225 for example, where the contents rather than json file path were used as a a key.) With LedgerHQ#38 the device name is used for the OS field instead, and so we are robust to confusing behavior around names.
yhql
pushed a commit
that referenced
this pull request
Aug 29, 2022
The first change is to parse once, and then use an enum for the device. This is hopefully a straightforward improvement. The second change is to case on the OS name (leveraging #38) instead of the target name. The target "name" isn't so structured, and it is unclear to what extent it should be anm exposed part of the target. (See rust-lang/rust#98225 for example, where the contents rather than json file path were used as a a key.) With #38 the device name is used for the OS field instead, and so we are robust to confusing behavior around names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hacking in the specific device in the
build.rs, which doesn't work for downstream packages, specify it as the "os" in the target json. Also specify "bolos" as atarget_familyto make a catch-allcfgfor any Ledger device easy too.