Remove all libcore codebase (#1831)

* Remove all libcore codebase

* trigger some bot (commit to revert before merging this PR)

* lint

* remove useless cli test run

* fix type issue

* cli update

* Revert "trigger some bot (commit to revert before merging this PR)"

This reverts commit add2667.

* update cli/README

* fix merge

* Cosmos js (#1832)

Document Nano app limitations + minor fix on reward amounts

* Modularize the all.libcore.tests (#1834)

* Additional cleanup on bitcoin implem

* LIVE-1873

Co-authored-by: wa-aal <93649819+wa-aal@users.noreply.github.com>
Co-authored-by: haammar-ledger <hakim.aammar-ext@ledger.fr>

.circleci.disabled/config.yml

@@ -155,6 +155,3 @@ jobs:
           paths:
             - ~/.cache/yarn
       - run: yarn ci-lint
-      - run:
-          command: yarn ci-test-cli
-          no_output_timeout: 1h

.eslintignore

@@ -1,9 +1,7 @@
 src/data/icons
 src/data/flags
 
-src/libcore/types/*.js
 src/families/*/types.js
-src/libcore/platforms/*.js
 src/generated
 src/load/tokens/
 mobile-test-app/

.github/workflows/test.yml

@@ -140,9 +140,6 @@ jobs:
           yarn global add yalc
           yarn --frozen-lockfile --network-timeout 100000
           yarn ci-setup-cli
-      - name: Run CLI tests
-        run: yarn ci-test-cli
-        timeout-minutes: 60
 
   cli:
     strategy:
@@ -163,6 +160,3 @@ jobs:
           yarn global add yalc
           yarn --frozen-lockfile --network-timeout 100000
           yarn ci-setup-cli
-      - name: Run CLI tests
-        run: yarn ci-test-cli
-        timeout-minutes: 60

.gitignore

@@ -1,6 +1,4 @@
 # See https://help.github.com/ignore-files/ for more about ignoring files.
-libcoredb/
-
 dbdata
 tmp
 

README.md

@@ -51,18 +51,16 @@ The stack is pretty standard for a ES6 and FlowType library. The notable depende
 - [Countervalues logic](./docs/countervalues.md)
 - Coin integration specifics
   - [Introduction](./docs/ci-intro.md)
-  - Bridge implementations, where to start? (JS, Libcore, Mock)
+  - Bridge implementations, where to start? (JS, Mock)
   - Implementing the hardware wallet logic of a new coin
   - [The account derivation (BIP44 and exceptions)](./docs/derivation.md)
 - Advanced
   - [api/socket `createDeviceSocket` and script runner](./docs/socket.md)
   - env.js: live-common configuration system
   - Serialization and reconciliation
-  - libcore typing and wrapping
   - cross.js and "LiveQR" protocol
   - cache.js helpers
   - Tokens management and ERC20
-  - [Developing with lib-ledger-core bindings](./docs/adding-libcore-bindings.md)
 
 ### Developing with Ledger Live Common
 

cli/package.json

@@ -18,10 +18,6 @@
     "build": "tsc --project src/tsconfig.json",
     "prepublishOnly": "rm -rf lib && tsc --project src/tsconfig.json",
     "watch": "tsc --watch --project src/tsconfig.json",
-    "test-e2e": "./scripts/tests.sh",
-    "test": "yarn run test-e2e",
-    "testOne": "./scripts/testOne.sh",
-    "createTest": "./scripts/createTest.sh",
     "type-check": "tsc --noEmit"
   },
   "peerDependencies": {
@@ -38,8 +34,7 @@
     "@ledgerhq/hw-transport-mocker": "6.24.1",
     "@ledgerhq/hw-transport-node-hid": "6.24.1",
     "@ledgerhq/hw-transport-node-speculos": "6.24.1",
-    "@ledgerhq/ledger-core": "6.14.5",
-    "@ledgerhq/live-common": "^21.34.0",
+    "@ledgerhq/live-common": "https://github.com/LedgerHQ/ledger-live-common.git#082c946830a332f764f3c95c0eb9c0572b493825",
     "@ledgerhq/logs": "6.10.0",
     "@walletconnect/client": "^1.7.1",
     "asciichart": "^1.5.25",

cli/src/commands-index.ts

@@ -25,11 +25,8 @@ import generateAppJsonFromDataset from "./commands/generateAppJsonFromDataset";
 import generateTestScanAccounts from "./commands/generateTestScanAccounts";
 import generateTestTransaction from "./commands/generateTestTransaction";
 import genuineCheck from "./commands/genuineCheck";
-import getAccountNetworkInfo from "./commands/getAccountNetworkInfo";
 import getAddress from "./commands/getAddress";
 import getTransactionStatus from "./commands/getTransactionStatus";
-import libcoreReset from "./commands/libcoreReset";
-import libcoreSetPassword from "./commands/libcoreSetPassword";
 import liveData from "./commands/liveData";
 import makeCompoundSummary from "./commands/makeCompoundSummary";
 import managerListApps from "./commands/managerListApps";
@@ -48,7 +45,6 @@ import sync from "./commands/sync";
 import testDetectOpCollision from "./commands/testDetectOpCollision";
 import testGetTrustedInputFromTxHash from "./commands/testGetTrustedInputFromTxHash";
 import user from "./commands/user";
-import validRecipient from "./commands/validRecipient";
 import version from "./commands/version";
 import walletconnect from "./commands/walletconnect";
 
@@ -80,11 +76,8 @@ export default {
   generateTestScanAccounts,
   generateTestTransaction,
   genuineCheck,
-  getAccountNetworkInfo,
   getAddress,
   getTransactionStatus,
-  libcoreReset,
-  libcoreSetPassword,
   liveData,
   makeCompoundSummary,
   managerListApps,
@@ -103,7 +96,6 @@ export default {
   testDetectOpCollision,
   testGetTrustedInputFromTxHash,
   user,
-  validRecipient,
   version,
   walletconnect,
 };

cli/src/commands/version.ts

@@ -1,7 +1,5 @@
 /* eslint-disable global-require, @typescript-eslint/no-var-requires */
-import { from, of, concat, Observable } from "rxjs";
-import { map } from "rxjs/operators";
-import { withLibcore } from "@ledgerhq/live-common/lib/libcore/access";
+import { of, concat, Observable } from "rxjs";
 
 export default {
   args: [],
@@ -11,13 +9,6 @@ export default {
       of(
         "@ledgerhq/live-common: " +
           require("@ledgerhq/live-common/package.json").version
-      ),
-      of(
-        "@ledgerhq/ledger-core: " +
-          require("@ledgerhq/ledger-core/package.json").version
-      ),
-      from(withLibcore((core) => core.LedgerCore.getStringVersion())).pipe(
-        map((v) => "libcore: " + v)
       )
     ),
 };

cli/src/live-common-setup-base.ts

@@ -3,7 +3,6 @@ import winston from "winston";
 import { EnvName, setEnvUnsafe } from "@ledgerhq/live-common/lib/env";
 import simple from "@ledgerhq/live-common/lib/logs/simple";
 import { listen } from "@ledgerhq/logs";
-import implementLibcore from "@ledgerhq/live-common/lib/libcore/platforms/nodejs";
 import { setSupportedCurrencies } from "@ledgerhq/live-common/lib/currencies";
 import { setPlatformVersion } from "@ledgerhq/live-common/lib/platform/version";
 
@@ -106,14 +105,11 @@ listen((log) => {
   const { type } = log;
   let level = "info";
 
-  if (type === "libcore-call" || type === "libcore-result") {
-    level = "silly";
-  } else if (
+  if (
     type === "apdu" ||
     type === "hw" ||
     type === "speculos" ||
-    type.includes("debug") ||
-    type.startsWith("libcore")
+    type.includes("debug")
   ) {
     level = "debug";
   } else if (type.includes("warn")) {
@@ -128,8 +124,3 @@ listen((log) => {
   // @ts-ignore
   logger.log(level, log);
 });
-implementLibcore({
-  lib: () => require("@ledgerhq/ledger-core"),
-  // eslint-disable-line global-require
-  dbPath: process.env.LIBCORE_DB_PATH || "./dbdata",
-});