Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

removed card live app from mocks #1915

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

IAmMorrow
Copy link
Contributor

@IAmMorrow IAmMorrow commented Apr 26, 2022

Description / Usage

Just removing the CL Card live apps from the mocks because some navigation is based on the availability of live apps and we don't wan't to test this particularly.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@IAmMorrow IAmMorrow requested a review from a team April 26, 2022 12:34
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 3, 2022 at 3:18PM (UTC)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1915 (d39d2f7) into develop (76e3f11) will decrease coverage by 9.61%.
The diff coverage is n/a.

❗ Current head d39d2f7 differs from pull request most recent head 17048e7. Consider uploading reports for the commit 17048e7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1915      +/-   ##
===========================================
- Coverage    69.03%   59.42%   -9.62%     
===========================================
  Files          545      510      -35     
  Lines        23507    21105    -2402     
  Branches      6185     5687     -498     
===========================================
- Hits         16229    12541    -3688     
- Misses        7237     8543    +1306     
+ Partials        41       21      -20     
Impacted Files Coverage Δ
src/families/bitcoin/networks.ts 5.88% <0.00%> (-80.40%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
src/families/crypto_org/js-signOperation.ts 20.31% <0.00%> (-70.32%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3f11...17048e7. Read the comment docs.

@IAmMorrow IAmMorrow merged commit 48756a4 into develop May 3, 2022
@IAmMorrow IAmMorrow deleted the mocks-remove-card-liveapp branch May 3, 2022 15:24
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants