Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-798 Bump libraries for FTS support #1916

Merged
merged 3 commits into from
Apr 27, 2022
Merged

LIVE-798 Bump libraries for FTS support #1916

merged 3 commits into from
Apr 27, 2022

Conversation

juan-cortes
Copy link
Contributor

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-798

Description / Usage

Just bumping the libraries that depend on either transport or devices since we added support for fts.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@juan-cortes juan-cortes requested a review from a team as a code owner April 26, 2022 13:06
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 27, 2022 at 1:18PM (UTC)

@juan-cortes
Copy link
Contributor Author

we probably need a 6.28 due to an out of sync package bumped without lerna
cc @gre @haammar-ledger

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1916 (6a2af82) into develop (76e3f11) will decrease coverage by 10.42%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1916       +/-   ##
============================================
- Coverage    69.84%   59.42%   -10.43%     
============================================
  Files          545      510       -35     
  Lines        23507    21105     -2402     
  Branches      6185     5687      -498     
============================================
- Hits         16419    12541     -3878     
- Misses        7045     8543     +1498     
+ Partials        43       21       -22     
Impacted Files Coverage Δ
src/families/bitcoin/networks.ts 5.88% <0.00%> (-80.40%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
src/families/crypto_org/js-signOperation.ts 20.31% <0.00%> (-70.32%) ⬇️
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3f11...6a2af82. Read the comment docs.

@juan-cortes juan-cortes merged commit bcd322c into develop Apr 27, 2022
@juan-cortes juan-cortes deleted the bump-libraries branch April 27, 2022 14:40
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants