Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dsdk 284 create CAL service loaders #6790

Merged
merged 2 commits into from
May 17, 2024
Merged

Feat/dsdk 284 create CAL service loaders #6790

merged 2 commits into from
May 17, 2024

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Apr 30, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Create the TokenLoader and ExternalPluginLoader that will get all the metadatas used to cleasign, from the CAL backend
This ticket is for:

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:20am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:20am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:20am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:20am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:20am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Apr 30, 2024
@aussedatlo aussedatlo changed the base branch from develop to feat/dsdk-285-context-module-nft April 30, 2024 15:48
lambertkevin
lambertkevin previously approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, just 1 minor comment open to debate I guess, other than that 🚀

libs/ledgerjs/packages/context-module/src/loaders/TokenLoader.ts Outdated Show resolved Hide resolved
@aussedatlo aussedatlo force-pushed the feat/dsdk-285-context-module-nft branch from a0a7bc9 to 5fe1e51 Compare May 3, 2024 08:28
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 8261cc8 to c23a6a8 Compare May 3, 2024 08:31
@aussedatlo aussedatlo force-pushed the feat/dsdk-285-context-module-nft branch from 5fe1e51 to 0938823 Compare May 3, 2024 08:52
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from c23a6a8 to df2bf9a Compare May 3, 2024 08:54
@aussedatlo aussedatlo force-pushed the feat/dsdk-285-context-module-nft branch from 0938823 to ecaf487 Compare May 7, 2024 07:34
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from df2bf9a to a06bb82 Compare May 7, 2024 07:37
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from a06bb82 to 2a17653 Compare May 10, 2024 07:58
@aussedatlo aussedatlo marked this pull request as draft May 10, 2024 12:18
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 2a17653 to 9b07f9b Compare May 10, 2024 12:19
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 9b07f9b to e037b6a Compare May 10, 2024 13:09
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from e037b6a to a4a577f Compare May 14, 2024 14:41
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from a4a577f to 897203b Compare May 14, 2024 15:00
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 897203b to b2068c6 Compare May 14, 2024 15:53
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from b2068c6 to e546470 Compare May 15, 2024 08:38
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from e546470 to 47ec609 Compare May 15, 2024 08:41
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 47ec609 to cb53f9f Compare May 16, 2024 08:23
@aussedatlo aussedatlo force-pushed the feat/dsdk-285-context-module-nft branch from ecaf487 to 550ff5f Compare May 16, 2024 10:25
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from cb53f9f to 0bde643 Compare May 16, 2024 10:32
@aussedatlo aussedatlo marked this pull request as ready for review May 16, 2024 10:37
@aussedatlo aussedatlo changed the base branch from feat/dsdk-285-context-module-nft to develop May 16, 2024 11:28
@aussedatlo aussedatlo dismissed lambertkevin’s stale review May 16, 2024 11:28

The base branch was changed.

@aussedatlo aussedatlo changed the base branch from develop to feat/dsdk-285-context-module-nft May 16, 2024 11:29
Base automatically changed from feat/dsdk-285-context-module-nft to develop May 16, 2024 11:52
lambertkevin
lambertkevin approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

libs/ledgerjs/packages/context-module/src/external-plugin/data/HttpExternalPluginDataSource.ts
Comment on lines +22 to +30
if (!erc20OfInterest || !method || !plugin || !signature || !serializedData) {
return;
}

const abi = dappInfos.data[0].abis?.[address];

if (!abi) {
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important for step 1, but I just hear from Alexis that "some contracts could not have an ABI in CAL", which would technically be possible I guess if we don't need to be looking for ERC20 addresses in the calldata 🤔

Just to keep in mind while we test the module if there is cases of plugin where only serializedData & signature would be provided 🤷‍♂️

libs/ledgerjs/packages/context-module/src/external-plugin/domain/ExternalPluginContextLoader.ts
Comment on lines +97 to +98
// In Solidity, a struct cannot begin with a number
// Additionally, when we use -1, it signifies the last element of the array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lambertkevin lambertkevin merged commit f72f4d5 into develop May 17, 2024
36 of 38 checks passed
@lambertkevin lambertkevin deleted the feat/dsdk-284-context-module-cal branch May 17, 2024 13:33
mcayuelas-ledger pushed a commit that referenced this pull request May 20, 2024
@aussedatlo @mcayuelas-ledger
Feat/dsdk 284 create CAL service loaders (#6790)
568f31c 
* feat(context-module): add token loader

* feat(context-module): add external plugin loader
lambertkevin pushed a commit that referenced this pull request May 20, 2024
@aussedatlo @lambertkevin
Feat/dsdk 284 create CAL service loaders (#6790)
d63f1a1 
* feat(context-module): add token loader

* feat(context-module): add external plugin loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnicoulaud-ledger jnicoulaud-ledger jnicoulaud-ledger left review comments

@lambertkevin lambertkevin lambertkevin approved these changes

Assignees

@aussedatlo aussedatlo

Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aussedatlo @lambertkevin @jnicoulaud-ledger