Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

EIP 1024 support #786

Merged
merged 3 commits into from
Jan 31, 2022
Merged

EIP 1024 support #786

merged 3 commits into from
Jan 31, 2022

Conversation

btchip
Copy link
Contributor

@btchip btchip commented Jan 31, 2022

This adds two primitives getEIP1024PublicEncryptionKey and getEIP1024SharedSecret to the Ethereum application to support EIP 1024 (https://ethereum-magicians.org/t/eip-1024-cross-client-encrypt-decrypt/505), used by decentralized identity providers

@btchip btchip requested a review from a team as a code owner January 31, 2022 13:14
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #786 (9fe4f88) into master (c1e3c0e) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   44.89%   45.15%   +0.26%     
==========================================
  Files          83       83              
  Lines        5030     5054      +24     
  Branches      892      894       +2     
==========================================
+ Hits         2258     2282      +24     
  Misses       2758     2758              
  Partials       14       14              
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 79.57% <100.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e3c0e...9fe4f88. Read the comment docs.

Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, new methods and commit with tests so it's safe to merge without impact 👍

Thanks

@gre gre merged commit d3ff6d0 into LedgerHQ:master Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants