Update Manifest schema [LIVE-9719] #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f7f78b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajv checks urls, simplifies regex schema update import ts schema in validator
Wozacosta
force-pushed
the
chore/LIVE-9719-update-manifest-schema
branch
from
6ec98b2
to
286f827
Compare
Justkant
requested changes
Apr 9, 2024
Comment on lines
130
to
141
| dapp: { | ||
| type: "object", | ||
| properties: { | ||
| nanoApp: { | ||
| minLength: 1, | ||
| maxLength: 50, | ||
| type: "string", | ||
| }, | ||
| networks, | ||
| }, | ||
| required: ["nanoApp", "networks"], | ||
| }, |
There was a problem hiding this comment.
We are missing the provider field here I think, like provider: "evm"
Justkant
approved these changes
Apr 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gist.github.com/Wozacosta/c0960fcbc624db81929509ff9282ff10
changelog
@ledgerhq/cryptoassetsinstead of the seemingly random mix of currencies we had before there..paramsfield check is cleaned up, only checkingparamsfield ifurl: { pattern: ".*dapp-browser.apps.ledger.com.*" } },"pattern": "^.*$",)checks are removed.typefield removed.platformfield fixed (https://gist.github.com/Wozacosta/c0960fcbc624db81929509ff9282ff10#platforms)versionfield tomanifestVersionfield (which seems to be standard in the doc and usage)next steps
use validator as github action in https://github.com/LedgerHQ/manifest-api
use regex pattern to validate semver here (https://gist.github.com/Wozacosta/c0960fcbc624db81929509ff9282ff10#apiversion)
update manifest documentation with following points :
remove mention of
typefield"platform": ["ios","android","desktop"]-> (should beplatforms)update doc with regex / min characters / max characters for string fields.
document content's
ctaandhighlightfieldsis the domains field actually used ? doc is missing cta
udpate doc for
visibility(https://gist.github.com/Wozacosta/c0960fcbc624db81929509ff9282ff10#visibility) - remove deep option