Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Release #9

Merged
merged 4 commits into from
Sep 8, 2023
Merged

ci: Release #9

merged 4 commits into from
Sep 8, 2023

Conversation

YDX-2147483647
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 commented Sep 8, 2023

  • Setup the release CI mentioned in CI for releases and manual generation? #8
  • Setup another CI that compiles and uploads the PDF, so that you can preview PRs.
  • Remove the PDF manual from this repo and update its links.
  • physicsphysica. (-s → -a)
  • Add badges.

Preview in my repo:

Fixes #8

@YDX-2147483647 YDX-2147483647 marked this pull request as ready for review September 8, 2023 03:52
@Leedehai Leedehai merged commit 5988611 into Leedehai:master Sep 8, 2023
@Leedehai
Copy link
Owner

Leedehai commented Sep 8, 2023

Isn't it wonderful?! Thanks!

@Leedehai
Copy link
Owner

Leedehai commented Sep 8, 2023

Hi - it appears the link in the PR content (https://github.com/Leedehai/typst-physics/releases/latest/download/physica-manual.pdf) doesn't work? It says "Not Found".

@YDX-2147483647
Copy link
Contributor Author

YDX-2147483647 commented Sep 9, 2023

Really sorry for that… Release permission is not granted.

Research:

The link in my repo works. It says not found because the latest release (https://github.com/Leedehai/typst-physics/releases/tag/v0.7.5) does not contain the manual (the release wasn't created by ci).

I've checked the log of release ci in your repo. The run failed because GitHub responded with 403 Forbidden.

GitHub forbids untrusted workflows to create releases: softprops/action-gh-release#236 (comment), softprops/action-gh-release#366 (comment), …

Could you try the following solution?

  1. Go to repo settings → (left bar) Actions → General → (scroll down) Workflow permissions , select Read and write permissions. Save.

    If it's already selected, that's ok.

  2. Add the following lines to .github/workflows/release.yml. (or merge ci: Allow the action to create a release #10)

    permissions:
      contents: write

    contents: write allows the action to create a release.

  3. Kick the ci. For example:

    $ git tag v0.7.5-alpha
    $ git push origin v0.7.5-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for releases and manual generation?
2 participants