Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get en name from desc.url #724

Closed
wants to merge 1 commit into from

Conversation

assumecs
Copy link

One might want to view the desc in Chinese. But the file name in Chinese which auto generated will cause problems when compile/debug on Windows with g++/gdb of Cygwin or MinGW.
It can be solved like this:

"leetcode.filePath": {
  "cpp": {
    "folder": "",
    "filename": "${id}.${ext}"
  }
}

But maybe it's better to add an en option.

"leetcode.filePath": {
  "cpp": {
    "folder": "",
    "filename": "${id}.${name_en}.${ext}"
  }
}

The name_en is parsed from desc url. There might be some better source.

@jdneo
Copy link
Member

jdneo commented Jul 28, 2021

Hi @assumecs,

Thank you for contribution. One concern is about the name_en. Since it might break if LeetCode changes the URL format. Do we have any other options to get the english name?

@assumecs
Copy link
Author

Hi @jdneo :
Thank you for reply.You're right, it's risky to parse the url.
I've found the property slug in leetcode-cli.It might be a better way to get the English filename #725 .

@assumecs assumecs closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants