Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LFAPI 1.9.2] Crash on Startup #161

Closed
thecatcore opened this issue Feb 20, 2024 · 0 comments · Fixed by #162
Closed

[LFAPI 1.9.2] Crash on Startup #161

thecatcore opened this issue Feb 20, 2024 · 0 comments · Fixed by #162
Labels
bug Something isn't working MC1.7.10 Related to Minecraft 1.7.10

Comments

@thecatcore
Copy link
Member

One mixin of the common networking module doesn't have the same signature between 1.7.10 and 1.8.9.
I'm surprised previous versions of LFAPI didn't crash in the same way because this code exists since API 1.7.0.
Culprit: https://github.com/Legacy-Fabric/fabric/blob/main/legacy-fabric-networking-api-v1/common/src/main/java/net/legacyfabric/fabric/mixin/networking/client/ClientPlayNetworkHandlerMixin.java#L50-L56
Logs: https://mclo.gs/CLrZjaA
MC1.8+ isn't affected.
@thecatcore thecatcore added bug Something isn't working MC1.7.10 Related to Minecraft 1.7.10 labels Feb 20, 2024
thecatcore added a commit to thecatcore/legacy-fabric-api that referenced this issue Feb 22, 2024
@thecatcore
Closes Legacy-Fabric#161
0619717
@thecatcore thecatcore mentioned this issue Feb 22, 2024
Merged
BluCobalt pushed a commit that referenced this issue Feb 22, 2024
@thecatcore
Fix crash on startup on MC1.7.10 (#162)
67279df 
* Closes #161

* Fix typo in package name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MC1.7.10 Related to Minecraft 1.7.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on startup on MC1.7.10 thecatcore/legacy-fabric-api
1 participant
@thecatcore