Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix command error output #148

Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix command error output #148

merged 3 commits into from
Dec 14, 2023

Conversation

RacoonDog
Copy link
Contributor

Replace usages of Text.toString() with Text.computeValue()

With test command /modmetadata (omitting argument to cause an error)

Current behaviour:
image

After changes:
image

@RickyTheRacc
Copy link

W

@RacoonDog
Copy link
Contributor Author

RacoonDog commented Aug 28, 2023

(Before merging, I actually need to change it to use Text.asUnformattedString() instead of Text.computeValue(). Atm it doesn’t cause any issues as is, but who knows)

@thecatcore
Copy link
Member

An additional review is needed here

@thecatcore thecatcore merged commit 3416787 into Legacy-Fabric:main Dec 14, 2023
1 check passed
@thecatcore thecatcore added this to the 1.9.2 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants