-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry sync v2 - Block Entity #173
Draft
thecatcore
wants to merge
54
commits into
Legacy-Fabric:feature/registry-sync-v2/main
Choose a base branch
from
thecatcore:feature/registry-sync-v2/block-entity
base: feature/registry-sync-v2/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Registry sync v2 - Block Entity #173
thecatcore
wants to merge
54
commits into
Legacy-Fabric:feature/registry-sync-v2/main
from
thecatcore:feature/registry-sync-v2/block-entity
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- differentiate "synced" Index-Key-Value registries from simple Key-Value registries - start preparing registry remapping
…c-v2/item # Conflicts: # legacy-fabric-registry-sync-api-v1/common.gradle
…egistry-sync-v2/item
…egistry-sync-v2/item
…egistry-sync-v2/item
…egistry-sync-v2/item
…egistry-sync-v2/item
…registry-sync-v2/block # Conflicts: # legacy-fabric-block-api-v1/1.12.2/src/main/java/net/legacyfabric/fabric/mixin/block/versioned/BlockMixin.java
…egistry-sync-v2/item
…registry-sync-v2/block
…/registry-sync-v2/block-entity
thecatcore
added
enhancement
New feature or request
new module
New module
bikeshed
yes
draft
labels
May 9, 2024
…egistry-sync-v2/item
…registry-sync-v2/block
…/registry-sync-v2/block-entity
…registry-sync-v2/api # Conflicts: # build.gradle
…egistry-sync-v2/item
…registry-sync-v2/block
…/registry-sync-v2/block-entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #167, #168 and #172.
For the real diff between #167, #168 and #172 and this, see thecatcore#3
What does this module do:
Should this be just merged into #172 instead of making a really small module just for Block entities?