Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-Sass is being deprecated, update to Dart Sass #452

Closed
Hopkinsa opened this issue Jul 6, 2021 · 3 comments · Fixed by #455
Closed

Node-Sass is being deprecated, update to Dart Sass #452

Hopkinsa opened this issue Jul 6, 2021 · 3 comments · Fixed by #455
Labels
released on @next released

Comments

@Hopkinsa
Copy link
Contributor

Hopkinsa commented Jul 6, 2021

From https://www.npmjs.com/package/node-sass

LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

This will result is a compile warning - DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

E.g.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($i, $columns)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
72 │   $width: percentage($i / $columns);
   │                      ^^^^^^^^^^^^^
   ╵
    node_modules/@legal-and-general/canopy/styles/grid.scss 72:22  @import
    resources/styles/styles_canopy.scss 7:9                        @import
    resources/styles/styles.scss 119:9                             root stylesheet

As part of update to Dart also update Sass to use math.div
@Hopkinsa Hopkinsa mentioned this issue Jul 8, 2021
Merged
Hopkinsa added a commit to Hopkinsa/canopy that referenced this issue Jul 9, 2021
@Hopkinsa
build(sass): migrates from node-sass to dart sass
6867f69 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix Legal-and-General#452
owensgit pushed a commit that referenced this issue Jul 9, 2021
@Hopkinsa @owensgit
build(sass): migrates from node-sass to dart sass
ba48ffa 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix #452
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

elenagarrone pushed a commit to elenagarrone/canopy that referenced this issue Jul 15, 2021
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
a0f2b25 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix Legal-and-General#452
elenagarrone pushed a commit that referenced this issue Jul 19, 2021
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
b626459 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix #452
elenagarrone pushed a commit that referenced this issue Jul 19, 2021
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
728d726 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix #452
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 7.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

elenagarrone pushed a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
0db15c2 
LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix Legal-and-General#452
elenagarrone pushed a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
d898353 
BREAKING CHANGE: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix Legal-and-General#452
elenagarrone pushed a commit that referenced this issue Feb 8, 2022
@Hopkinsa @elenagarrone
build(sass): migrates from node-sass to dart sass
6580bad 
BREAKING CHANGE: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases
indefinitely, there are no plans to add additional features or compatibility with any new CSS or
Sass features. Projects that still use it should move onto Dart Sass

https://sass-lang.com/blog/libsass-is-deprecated

fix #452
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(sass): migrate from node-sass to dart sass Hopkinsa/canopy
1 participant
@Hopkinsa