Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update secondLogo input name to secondaryLogo (header and footer) #670

Closed
elenagarrone opened this issue Jan 11, 2022 · 2 comments
Closed

Update secondLogo input name to secondaryLogo (header and footer) #670

elenagarrone opened this issue Jan 11, 2022 · 2 comments
Labels
breaking change An issue that when resolved will be a breaking change enhancement New feature or request good first issue Good for newcomers released on @next released

Comments

@elenagarrone
Copy link
Contributor

Update inputs for header and footer components from secondLogo to secondaryLogo for consistency.

This will be a breaking change so it needs to go into the next branch.
@elenagarrone elenagarrone added enhancement New feature or request good first issue Good for newcomers breaking change An issue that when resolved will be a breaking change labels Jan 11, 2022
elenagarrone added a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@elenagarrone
refactor(header): update variable name for secondary logo
095c0ed 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: Legal-and-General#670
elenagarrone added a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@elenagarrone
refactor(footer): update variable name for secondary logo
86ed35d 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: Legal-and-General#670
elenagarrone added a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@elenagarrone
refactor(header): update input name for secondary logo
1697fde 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: Legal-and-General#670
elenagarrone added a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@elenagarrone
refactor(footer): update input name for secondary logo
acb8cbb 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: Legal-and-General#670
@elenagarrone elenagarrone mentioned this issue Feb 3, 2022
Merged
6 tasks
elenagarrone added a commit that referenced this issue Feb 3, 2022
@elenagarrone
refactor(header): update input name for secondary logo
2d273e8 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: #670
elenagarrone added a commit that referenced this issue Feb 3, 2022
@elenagarrone
refactor(footer): update input name for secondary logo
ff7ad48 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: #670
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

🎉 This issue has been resolved in version 7.0.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

elenagarrone added a commit that referenced this issue Feb 8, 2022
@elenagarrone
refactor(footer): update input name for secondary logo
8d3a965 
BREAKING CHANGE: the input for the second logo has been
changed from `secondLogo` to `secondaryLogo`.

fix: #670
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change An issue that when resolved will be a breaking change enhancement New feature or request good first issue Good for newcomers released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elenagarrone