Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link styles to banner message #1487

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add link styles to banner message #1487

merged 2 commits into from
Dec 4, 2024

Conversation

mchand
Copy link
Contributor

@mchand mchand commented Dec 2, 2024

Description

  • adds link colours to the banner message component so any links used in the projected content are contrast compliant
  • adds a container to the projected content so links are aligned correctly (and to allow for dismiss functionality later)
  • adds link text to the component example

Fixes #1417

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

@mchand mchand requested a review from a team as a code owner December 2, 2024 16:17
elenagarrone
elenagarrone approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@elenagarrone elenagarrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 👏 and congrats on your first Canopy PR 🎉

@github-actions github-actions bot added the deployed The branch is deployed to GitHub Pages label Dec 4, 2024
@elenagarrone
Copy link
Contributor

Just deployed and it's looking good:
image
image

@elenagarrone elenagarrone enabled auto-merge (rebase) December 4, 2024 10:48
@elenagarrone elenagarrone merged commit aadae33 into Legal-and-General:master Dec 4, 2024
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 12.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xinchro Xinchro Xinchro approved these changes

@elenagarrone elenagarrone elenagarrone approved these changes

Assignees
No one assigned
Labels
deployed The branch is deployed to GitHub Pages released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Banner message content link colours are not contrast compliant
3 participants
@mchand @elenagarrone @Xinchro