Does not handle missing repository url.

[remotezygote]

Environment

• Version: 0.4.7
• package manager: yarn
• directory structure: yarn workspaces

Overview

When out-of-date packages are found, hothouse tries to get the repository url for each package, but some packages do not have a repository section at all (this is fairly common).

Actual behavior

  hothouse:fetchReleases Try to fetch tag of wdio-mocha-framework@0.5.13 +0ms
  hothouse:fetchReleases Try to fetch tag of react-textarea-autosize@6.1.0 +0ms
  hothouse:fetchReleases Try to fetch tag of twitter-text@1.9.4 +0ms
TypeError: Cannot read property 'url' of undefined
    at Package.getRepositoryHttpsUrl (/Users/john/.config/yarn/global/node_modules/hothouse/dist/Package.js:54:58)
    at getUpdateDetail (/Users/john/.config/yarn/global/node_modules/hothouse/dist/tasks/fetchReleases.js:53:29)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Please report issue from here: https://github.com/Leko/hothouse/issues
TypeError: Cannot read property 'url' of undefined
    at Package.getRepositoryHttpsUrl (/Users/john/.config/yarn/global/node_modules/hothouse/dist/Package.js:54:58)
    at getUpdateDetail (/Users/john/.config/yarn/global/node_modules/hothouse/dist/tasks/fetchReleases.js:53:29)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Please report issue from here: https://github.com/Leko/hothouse/issues

Expected behavior

No errors. Not sure what is after this since this is as far as I have gotten so far.

[remotezygote]

More info from package.jsons:

wdio-mocha-framework:

  "repository": {
    "type": "git",
    "url": "git+https://github.com/webdriverio/wdio-mocha-framework.git"
  },

react-textarea-autosize:
"repository": "andreypopp/react-textarea-autosize",

twitter-text :

  "repository": {
    "type": "git",
    "url": "https://github.com/twitter/twitter-text-js.git"
  },

So not sure what is going on here...

(These are extracted from the correct versions of these packages from the error above)

[remotezygote]

Looks like possibly unreleased changes might fix this.

[remotezygote]

What is on master still does not work. I verified locally.

[Leko]

Thanks for reporting.

When repository.url is not present, hothouse should not try to fetch tag and releases.
I’ll fix this issue.

[Leko]

@remotezygote I'm sorry for late reply. I took a week off.

I fixed this issue by these commits.
3e6fbe9
29d4547
And I just released a new version of hothouse@0.4.8.

If you still have any problem, please re-open this issue.
Thanks.

[remotezygote]

No worries! Time off is important. Thanks a bunch! I'll try it now.

[remotezygote]

It works! Thanks so much!