This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Remove creator from SiteView and Site parameters #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilangyu
suggested changes
Apr 30, 2022
| @@ -65,7 +65,6 @@ class SiteView with _$SiteView { | |||
| @JsonSerializable(fieldRename: FieldRename.snake) | |||
| const factory SiteView({ | |||
| required Site site, | |||
| required PersonSafe creator, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually... It was removed, but not updated in the TS api client! Nice catch! https://github.com/LemmyNet/lemmy/blob/dd5835fb6ee210af78ba876bf3e9f37ea1db521b/crates/db_views/src/site_view.rs#L10
Will send a PR to the TS repo
There was a problem hiding this comment.
shilangyu
force-pushed
the
fix-site-class
branch
from
cd7acb0
to
3549eeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the
creatorparameter have been removed from Site and SiteView (It seems to have been replaced by admins). Just setting the variable as nullable makes the "Add Instance" function in Lemmur work again.